Skip to content

Bug fix for subplot() #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2015
Merged

Bug fix for subplot() #266

merged 1 commit into from
Aug 14, 2015

Conversation

cpsievert
Copy link
Collaborator

Fixes #265

@cpsievert cpsievert changed the title get_domains() sometimes returns a df of different dimensions from p_info Bug fix for subplot() Aug 14, 2015
@chriddyp
Copy link
Member

nice, thanks! 💃

cpsievert added a commit that referenced this pull request Aug 14, 2015
@cpsievert cpsievert merged commit 257a0c1 into master Aug 14, 2015
@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/75671149

On TravisCI, commit d4e2143 was successfully merged with c6eb180 (master) to create c163444. A visual testing table comparing c6eb180 with c163444 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/c163444/

Detected 2 differences ->

http://cpsievert.github.io/plotly-test-table/R/c163444//plotly-subplot-simple2
http://cpsievert.github.io/plotly-test-table/R/c163444//plotly-subplot-simple

@cpsievert cpsievert deleted the fix-subplot branch November 20, 2015 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants